Go rewrite copy comments script #11715
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
#11713 needs to be merged first before this PR. |
| copyComments() | ||
| } | ||
|
|
||
| // TODO rewrite: ServicePerimeters.yaml is an exeption and needs manually fixing the comments over after switchover |
There was a problem hiding this comment.
Will ServicePerimeters.yaml block future automatic refreshes or the comment just won't be copied over
There was a problem hiding this comment.
No, ServicePerimeters.yaml will not block the automatic refreshes.
The comments of ServicePerimeters.yaml are copied to the Go yaml files. But the copied comments are not accurate and need to be fixed after the switch over.
zli82016
force-pushed
the
go-rewrite-copy-comments-script
branch
from
d812257
to
4311808
Compare
zli82016
force-pushed
the
go-rewrite-copy-comments-script
branch
from
4311808
to
407dd81
Compare
|
Rebased the main branch to fix the conflicts and added more fields to renamedFields. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Release Note Template for Downstream PRs (will be copied)